Add Dockerfile #297
Merged
Add Dockerfile #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marema31
force-pushed
the
Dockerfile
branch
2 times, most recently
from
167da3d
to
668d3c1
Compare
|
Hello @marema31, Thanks for your PR. It will be interesting to be able to start a Docker image with a specific version of Venom. |
|
Hi @marema31 , Before making a release, we do a lot of testing to get the most stable version possible. We don't want to promote the master branch as a stable branch for 'production' use. The master branch can contain some breaking changes, it's not a good idea to run venom as is, without knowing which changes can break your existing tests. Here, a dockerfile with the latest release: FROM debian:buster-slim
RUN apt-get update && \
apt-get install -y curl unixodbc && \
rm -rf /var/lib/apt/lists/*
RUN LAST_RELEASE=$(curl -s https://api.github.com/repos/ovh/venom/releases | grep tag_name | head -n 1 | cut -d '"' -f 4) && \
todl=$(curl -s https://api.github.com/repos/ovh/venom/releases | grep ${LAST_RELEASE} | grep browser_download_url | grep -E 'venom.linux-amd64' | cut -d '"' -f 4) && \
curl -s $todl -L -o /opt/venom && \
chmod +x /opt/venom
ENTRYPOINT ["/opt/venom" ]
CMD [ "run", "--output-dir", "/outputs"]And we will provide official image on docker hub for the next release. |
yesnault
requested changes
Nov 13, 2020
marema31
commented
Nov 13, 2020
Signed-off-by: Marc Carmier <mcarmier@gmail.com>
Signed-off-by: Marc Carmier <mcarmier@gmail.com>
Sure, if it respect your release cycle, it should be done like this Co-authored-by: Yvonnick Esnault <yvonnick@esnau.lt> Signed-off-by: Marc Carmier <mcarmier@gmail.com>
Signed-off-by: Marc Carmier <mcarmier@gmail.com>
yesnault
approved these changes
Nov 17, 2020
fsamin
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a docker image